refactor(ndt_scan_matcher): hierarchize parameters #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <[email protected]>
github-actions
bot
added
the
component:localization
4 tasks
YamatoAndo
requested review from
KYabuuchi,
kminoda,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
Signed-off-by: Yamato Ando <[email protected]>
Signed-off-by: Yamato Ando <[email protected]>
4 tasks
SakodaShintaro
approved these changes
Jan 31, 2024
YamatoAndo
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6208 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1878 1879 +1
Lines 128023 128032 +9
Branches 37468 37469 +1
=======================================
+ Hits 18671 18675 +4
- Misses 88377 88384 +7
+ Partials 20975 20973 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Feb 1, 2024
…n#6208) * refactor(ndt_scan_matcher): hierarchize parameters Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * add new lines Signed-off-by: Yamato Ando <[email protected]> * fix typo Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Feb 1, 2024
…n#6208) * refactor(ndt_scan_matcher): hierarchize parameters Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * add new lines Signed-off-by: Yamato Ando <[email protected]> * fix typo Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…n#6208) * refactor(ndt_scan_matcher): hierarchize parameters Signed-off-by: Yamato Ando <[email protected]> * style(pre-commit): autofix * add new lines Signed-off-by: Yamato Ando <[email protected]> * fix typo Signed-off-by: Yamato Ando <[email protected]> --------- Signed-off-by: Yamato Ando <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with autowarefoundation/autoware_launch#830
Description
hierarchized the parameters in the
config/ndt_scan_matcher.param.yamlfile.Additionally, I made the following changes:
RCLCPP_INFOoutput after loading parameters (as it is unnecessary to display).input_sensor_points_queue_size(as there is no situation where this parameter changes, I fixed it to a constant value).※Regarding the README, I plan to submit a PR introducing the JSON schema shortly after merging this PR, and I will update the README at that time. #6229
Tests performed
LSim works
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.